chore: bump doc-store version to include postgres impl of exits, not-exits and neq#23
Merged
Merged
Conversation
kotharironak
requested review from
GurtejSohi,
aaron-steinfeld,
buchi-busireddy and
pavan-traceable
as code owners
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
=========================================
Coverage 89.68% 89.68%
Complexity 105 105
=========================================
Files 14 14
Lines 378 378
Branches 16 16
=========================================
Hits 339 339
Misses 32 32
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
previously approved these changes
Feb 15, 2021
This comment has been minimized.
This comment has been minimized.
| testFixturesAnnotationProcessor("org.projectlombok:lombok:1.18.12") | ||
| testFixturesCompileOnly("org.projectlombok:lombok:1.18.12") | ||
|
|
||
| runtimeOnly("io.netty:netty-codec-http2:4.1.59.Final") |
Contributor
There was a problem hiding this comment.
Same comment as attribute service - please move these back into constraints block (and indicate the corresponding cause of the constraint)
This comment has been minimized.
This comment has been minimized.
| } | ||
| runtimeOnly("io.netty:netty-codec-http2:4.1.53.Final") { | ||
| runtimeOnly("io.netty:netty-codec-http2:4.1.59.Final") { | ||
| because("https://snyk.io/vuln/SNYK-JAVA-IONETTY-1020439") |
Contributor
There was a problem hiding this comment.
can you update this with the new netty issue?
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
approved these changes
Feb 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates doc-store version to include postgres impl of exists, not-exists, and NEQ filters