Skip to content

bugfix: MockGenericConfigService - set timestamps in response#30

Merged
GurtejSohi merged 7 commits into
mainfrom
expose-creation-and-update-timestamp-in-upsert-config-response
Mar 3, 2021
Merged

bugfix: MockGenericConfigService - set timestamps in response#30
GurtejSohi merged 7 commits into
mainfrom
expose-creation-and-update-timestamp-in-upsert-config-response

Conversation

@GurtejSohi
Copy link
Copy Markdown
Collaborator

In the PR for exposing creation and update timestamp in UpsertConfigResponse, I missed setting the timestamps in UpsertConfigResponse in MockGenericConfigService. This change fixes it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2021

Codecov Report

Merging #30 (88b2813) into main (d8d541a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #30   +/-   ##
=========================================
  Coverage     90.50%   90.50%           
  Complexity      109      109           
=========================================
  Files            14       14           
  Lines           400      400           
  Branches         18       18           
=========================================
  Hits            362      362           
  Misses           32       32           
  Partials          6        6           
Flag Coverage Δ Complexity Δ
integration 90.50% <ø> (ø) 0.00 <ø> (ø)
unit 88.38% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d541a...88b2813. Read the comment docs.

@github-actions

This comment has been minimized.

@GurtejSohi GurtejSohi merged commit 69a7275 into main Mar 3, 2021
@GurtejSohi GurtejSohi deleted the expose-creation-and-update-timestamp-in-upsert-config-response branch March 3, 2021 17:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2021

Unit Test Results

10 files  ±0  10 suites  ±0   6s ⏱️ -1s
31 tests ±0  31 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 69a7275. ± Comparison against base commit d8d541a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants