ENG-11061: Adding implementation corresponding to tags config service apis#48
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
============================================
+ Coverage 90.80% 91.71% +0.91%
- Complexity 111 130 +19
============================================
Files 14 16 +2
Lines 424 519 +95
Branches 19 19
============================================
+ Hits 385 476 +91
- Misses 32 36 +4
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
jcchavezs
reviewed
Aug 23, 2021
jcchavezs
reviewed
Aug 23, 2021
jcchavezs
reviewed
Aug 23, 2021
jcchavezs
reviewed
Aug 23, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
saxenakshitiz
previously approved these changes
Aug 24, 2021
| RequestContext requestContext = RequestContext.CURRENT.get(); | ||
| Tag updatedTagInReq = request.getTag(); | ||
| configServiceCoordinator.getTag(requestContext, updatedTagInReq.getId()); | ||
| Tag updatedTagInRes = configServiceCoordinator.upsertTag(requestContext, request.getTag()); |
Contributor
There was a problem hiding this comment.
use updatedTagInReq instead of request.getTag()
saxenakshitiz
approved these changes
Aug 24, 2021
saxenakshitiz
changed the title
jcchavezs
reviewed
Aug 24, 2021
| import org.hypertrace.tag.config.service.v1.UpdateTagResponse; | ||
|
|
||
| @Slf4j | ||
| public class TagConfigServiceImpl extends TagConfigServiceGrpc.TagConfigServiceImplBase { |
jcchavezs
reviewed
Aug 24, 2021
| try { | ||
| RequestContext requestContext = RequestContext.CURRENT.get(); | ||
| String tagId = request.getId(); | ||
| configServiceCoordinator.getTag(requestContext, tagId); |
There was a problem hiding this comment.
I am curious about this one. Do we truly need to check if tag exists before delete it? This operations don't seem to happen transactionally so after you get a tag and before you delete it, tag might be gone already. If delete is idempotent (which I believe it should), then I would just attempt to delete.
Contributor
There was a problem hiding this comment.
@kamaleshnneerasa mentioned that there was a NPE when you attempt to delete a non-existent tag-id. You are right that we should fix it appropriately in root config service such that all config services are benefitted by this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.