Skip to content

Conversation

@SrikarMannepalli
Copy link
Contributor

Description

Added event time to configChangeEventValue

@SrikarMannepalli SrikarMannepalli requested review from aaron-steinfeld and saxenakshitiz and removed request for saxenakshitiz October 20, 2021 16:00
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #74 (b7e9810) into main (32a08ce) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #74      +/-   ##
============================================
+ Coverage     84.20%   84.27%   +0.06%     
  Complexity      286      286              
============================================
  Files            36       36              
  Lines          1412     1418       +6     
  Branches         45       45              
============================================
+ Hits           1189     1195       +6     
  Misses          194      194              
  Partials         29       29              
Flag Coverage Δ
integration 84.27% <100.00%> (+0.06%) ⬆️
unit 83.39% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../event/impl/ConfigChangeEventGeneratorFactory.java 100.00% <100.00%> (ø)
...nge/event/impl/ConfigChangeEventGeneratorImpl.java 91.89% <100.00%> (+0.58%) ⬆️
...pertrace/config/service/ConfigServicesFactory.java 64.28% <100.00%> (+2.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a08ce...b7e9810. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@SrikarMannepalli SrikarMannepalli merged commit 91b1b34 into main Oct 20, 2021
@SrikarMannepalli SrikarMannepalli deleted the add-event-time-to-configChangeEventValue branch October 20, 2021 18:44
@github-actions
Copy link

Unit Test Results

21 files  ±0  21 suites  ±0   39s ⏱️ +3s
77 tests ±0  77 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 91b1b34. ± Comparison against base commit 32a08ce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants