Correct the atomic update Postgres implementation#130
Merged
suresh-prakash merged 1 commit intomainfrom Sep 28, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
=========================================
Coverage 79.11% 79.11%
Complexity 631 631
=========================================
Files 103 103
Lines 2945 2945
Branches 274 274
=========================================
Hits 2330 2330
Misses 449 449
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
kotharironak
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The atomic update implementation of Postgres was skipping the locked rows. But, this could create problems if the filtered rows are not updated. This PR removes this optimisation step to favour correctness.
Testing
Fixed unit test and added integration test
Checklist: