Skip to content

Comments

Correct the atomic update Postgres implementation#130

Merged
suresh-prakash merged 1 commit intomainfrom
atomic_update_postgres_fix
Sep 28, 2022
Merged

Correct the atomic update Postgres implementation#130
suresh-prakash merged 1 commit intomainfrom
atomic_update_postgres_fix

Conversation

@suresh-prakash
Copy link
Contributor

Description

The atomic update implementation of Postgres was skipping the locked rows. But, this could create problems if the filtered rows are not updated. This PR removes this optimisation step to favour correctness.

Testing

Fixed unit test and added integration test

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #130 (e478799) into main (27ed49c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #130   +/-   ##
=========================================
  Coverage     79.11%   79.11%           
  Complexity      631      631           
=========================================
  Files           103      103           
  Lines          2945     2945           
  Branches        274      274           
=========================================
  Hits           2330     2330           
  Misses          449      449           
  Partials        166      166           
Flag Coverage Δ
integration 79.11% <100.00%> (ø)
unit 53.61% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore/documentstore/postgres/PostgresCollection.java 74.00% <100.00%> (ø)
...ntstore/postgres/query/v1/PostgresQueryParser.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

@suresh-prakash suresh-prakash merged commit f460df3 into main Sep 28, 2022
@suresh-prakash suresh-prakash deleted the atomic_update_postgres_fix branch September 28, 2022 10:53
@github-actions
Copy link

Unit Test Results

  17 files  ±0    17 suites  ±0   12s ⏱️ +3s
125 tests ±0  125 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
283 runs  +2  283 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit f460df3. ± Comparison against base commit 27ed49c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants