Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

Reverse the deserialization priority, so the most recently registered deserializers have priority. Previously, priority was given to the earliest registered. This switch makes it easier to add custom deserializers after bootstrap, as the built in ones already cover all data types and would intercept any json value before it got to a late registration.

Testing

Updated unit tests

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner December 3, 2020 21:33
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #122 (7e9d51d) into main (811f627) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines         1429      1429           
  Branches       194       194           
=========================================
  Hits          1429      1429           
Impacted Files Coverage Δ
...istence/deserialization/deserialization-manager.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 811f627...7e9d51d. Read the comment docs.

@aaron-steinfeld aaron-steinfeld merged commit d298c8a into main Dec 3, 2020
@aaron-steinfeld aaron-steinfeld deleted the reverse-deserialization-priority branch December 3, 2020 21:39
@hypertrace-ci
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants