feat: Integrate with Gateway log api #56

findingrish · 2021-04-21T16:47:44Z

Request/Response:

{
  logEvents(
        limit: 2
        between: {
           startTime:  "2021-04-21T12:07:14.144Z", 
           endTime: "2021-04-21T13:07:14.144Z"
       }
       filterBy: [
          {
              key: "traceId"
              operator: EQUALS
               value: "000000000000000024c91c2019db1636"
               type: ATTRIBUTE
          }
        ]
  ) {
    results {
      traceId: attribute(key: "traceId")
      spanId: attribute(key: "spanId")
      attributes: attribute(key: "attributes")
      time: attribute(key: "timestamp")
      __typename
    }
    total
    __typename
  }
}

{
  "data": {
    "logEvents": {
      "results": [
        {
          "traceId": "000000000000000024c91c2019db1636",
          "spanId": "54d4affeb3dd3ff7",
          "attributes": {
            "event": "Acquired lock with 0 transactions waiting behind"
          },
          "time": "2021-04-21T13:05:08.201820Z",
          "__typename": "LogEvent"
        },
        {
          "traceId": "000000000000000024c91c2019db1636",
          "spanId": "01baa737826f3cc6",
          "attributes": {
            "event": "GetConn"
          },
          "time": "2021-04-21T13:05:08.198296Z",
          "__typename": "LogEvent"
        }
      ],
      "total": 2,
      "__typename": "LogEventResultSet"
    }
  }
}

...e-utils/src/main/java/org/hypertrace/core/graphql/utils/gateway/UnwrappedValueConverter.java

hypertrace-core-graphql-gateway-service-utils/build.gradle.kts

...src/main/java/org/hypertrace/core/graphql/common/request/DefaultAttributeRequestBuilder.java

...e-utils/src/main/java/org/hypertrace/core/graphql/utils/gateway/UnwrappedValueConverter.java

...chema/src/main/java/org/hypertrace/core/graphql/log/event/dao/GatewayServiceLogEventDao.java

...java/org/hypertrace/core/graphql/log/event/dao/GatewayServiceLogEventsResponseConverter.java

...vent-schema/src/main/java/org/hypertrace/core/graphql/log/event/fetcher/LogEventFetcher.java

findingrish · 2021-04-22T09:18:55Z

Build would pass once the gateway pr is merged and its version is updated.

...ice-utils/src/main/java/org/hypertrace/core/graphql/utils/gateway/WrappedValueConverter.java

aaron-steinfeld · 2021-04-22T15:39:30Z

...ema/src/main/java/org/hypertrace/core/graphql/common/schema/typefunctions/UnknownScalar.java

              new Coercing<>() {
                @Override
                public Object serialize(Object fetcherResult) throws CoercingSerializeException {
+                  if (fetcherResult instanceof Instant) {


We'll need to be handle the other direction, too. Both from the transport string to instant, and from instant to the gateway format. I'm ok deferring that if you want to leave a TODO since the only place where this would come up is passing in values to filters, but we generally filter timestamps via the first class time range.

yeah, that is why I skipped. I will add a todo at the moment.

, and from instant to the gateway format.

What do you mean by this? instant to gateway format conversion isn't done here?

LiteralConstantConverter - the conversion from a java primitive/object into the gateway argument format. This spot does the conversion from the serialized format from http into the java primitive/object.

...ice-utils/src/main/java/org/hypertrace/core/graphql/utils/gateway/AttributeMapConverter.java

...eway-service-utils/src/main/java/org/hypertrace/core/graphql/utils/gateway/ValueWrapper.java

...java/org/hypertrace/core/graphql/log/event/dao/GatewayServiceLogEventsResponseConverter.java

...c/main/java/org/hypertrace/core/graphql/log/event/request/DefaultLogEventRequestBuilder.java

codecov · 2021-04-22T17:31:48Z

Codecov Report

Merging #56 (31930d1) into main (f627973) will decrease coverage by 0.34%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##               main      #56      +/-   ##
============================================
- Coverage     61.83%   61.48%   -0.35%     
- Complexity      230      233       +3     
============================================
  Files            77       77              
  Lines          1158     1171      +13     
  Branches         31       33       +2     
============================================
+ Hits            716      720       +4     
- Misses          417      423       +6     
- Partials         25       28       +3

Flag	Coverage Δ	Complexity Δ
unit	`61.48% <25.00%> (-0.35%)`	`233.00 <3.00> (+3.00)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...hql/common/schema/typefunctions/UnknownScalar.java	`64.86% <0.00%> (-3.71%)`	`5.00 <0.00> (ø)`
...e/graphql/utils/gateway/AttributeMapConverter.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...core/graphql/utils/gateway/GatewayUtilsModule.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...raphql/utils/gateway/LiteralConstantConverter.java	`100.00% <ø> (ø)`	`11.00 <0.00> (ø)`
...graphql/utils/gateway/UnwrappedValueConverter.java	`16.66% <40.00%> (+16.66%)`	`3.00 <3.00> (+3.00)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f627973...31930d1. Read the comment docs.

aaron-steinfeld

lgtm - could you add a couple strategic tests (maybe the timestamp conversion, request and response builders)?

findingrish · 2021-04-22T20:46:03Z

lgtm - could you add a couple strategic tests (maybe the timestamp conversion, request and response builders)?

Added, let me know if this is fine.

github-actions · 2021-04-23T15:43:48Z

Unit Test Results

29 files +1 29 suites +1 25s ⏱️ -2s
99 tests +1 99 ✔️ +1 0 💤 ±0 0 ❌ ±0

Results for commit 1e1c09e. ± Comparison against base commit f627973.

Add concrete impl

940c4ed

findingrish requested review from aaron-steinfeld, kotharironak and skjindal93 April 21, 2021 16:48

findingrish commented Apr 21, 2021

View reviewed changes

...e-utils/src/main/java/org/hypertrace/core/graphql/utils/gateway/UnwrappedValueConverter.java Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Request timestamp is in millis

e58157f

This comment has been minimized.

Sign in to view

spotless

8a29479

This comment has been minimized.

Sign in to view

findingrish mentioned this pull request Apr 21, 2021

feat: Api for log event hypertrace/gateway-service#87

Merged

aaron-steinfeld reviewed Apr 21, 2021

View reviewed changes

review comment

7d1f6e4

findingrish marked this pull request as ready for review April 22, 2021 09:18

findingrish requested a review from a team as a code owner April 22, 2021 09:18

kotharironak reviewed Apr 22, 2021

View reviewed changes

...ice-utils/src/main/java/org/hypertrace/core/graphql/utils/gateway/WrappedValueConverter.java Outdated Show resolved Hide resolved

aaron-steinfeld reviewed Apr 22, 2021

View reviewed changes

rish691 added 3 commits April 22, 2021 22:34

Use biconverter

4af1393

review comment

05e45ef

update gateway version

148af97

This comment has been minimized.

Sign in to view

Add todo

e1b2be7

This comment has been minimized.

Sign in to view

aaron-steinfeld reviewed Apr 22, 2021

View reviewed changes

Add test

31930d1

This comment has been minimized.

Sign in to view

aaron-steinfeld approved these changes Apr 23, 2021

View reviewed changes

findingrish merged commit 1e1c09e into main Apr 23, 2021

findingrish deleted the gateway-log-event-integration branch April 23, 2021 15:42

feat: Integrate with Gateway log api #56

feat: Integrate with Gateway log api #56

Uh oh!

Conversation

findingrish commented Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

findingrish commented Apr 22, 2021

Uh oh!

Uh oh!

aaron-steinfeld Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

findingrish Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

findingrish Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaron-steinfeld Apr 22, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

codecov bot commented Apr 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

aaron-steinfeld left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

findingrish commented Apr 22, 2021

Uh oh!

github-actions bot commented Apr 23, 2021

Unit Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

findingrish commented Apr 21, 2021 •

edited

Loading

findingrish Apr 22, 2021 •

edited

Loading

codecov bot commented Apr 22, 2021 •

edited

Loading