Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

Excessive error construction was eating up CPU cycles - changed to lazy construction, and added a throttled log message

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #230 (80a177a) into main (cebd6ee) will decrease coverage by 0.04%.
The diff coverage is 46.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #230      +/-   ##
============================================
- Coverage     80.47%   80.43%   -0.05%     
- Complexity     1125     1126       +1     
============================================
  Files           101      101              
  Lines          4349     4355       +6     
  Branches        400      400              
============================================
+ Hits           3500     3503       +3     
- Misses          659      662       +3     
  Partials        190      190              
Flag Coverage Δ
unit 80.43% <46.15%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../trace/reader/attributes/DefaultValueResolver.java 83.33% <46.15%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cebd6ee...80a177a. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 34e7e54 into main Jul 21, 2021
@aaron-steinfeld aaron-steinfeld deleted the lazy-errors branch July 21, 2021 23:03
@github-actions
Copy link

Unit Test Results

  69 files  ±0    69 suites  ±0   45s ⏱️ -4s
359 tests ±0  359 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 34e7e54. ± Comparison against base commit cebd6ee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants