Skip to content

fix: change error create to be lazy #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2021
Merged

fix: change error create to be lazy #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions ...ace-reader/src/main/java/org/hypertrace/trace/reader/attributes/DefaultValueResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@

import static io.reactivex.rxjava3.core.Single.zip;

import com.google.common.util.concurrent.RateLimiter;
import io.reactivex.rxjava3.core.Maybe;
import io.reactivex.rxjava3.core.Observable;
import io.reactivex.rxjava3.core.Single;
import java.util.List;
import java.util.stream.Collectors;
import lombok.extern.slf4j.Slf4j;
import org.hypertrace.core.attribute.service.cachingclient.CachingAttributeClient;
import org.hypertrace.core.attribute.service.projection.AttributeProjection;
import org.hypertrace.core.attribute.service.projection.AttributeProjectionRegistry;
Expand All @@ -21,7 +23,10 @@
import org.hypertrace.core.attribute.service.v1.Projection;
import org.hypertrace.core.attribute.service.v1.ProjectionExpression;

@Slf4j
class DefaultValueResolver implements ValueResolver {
// One log a minute
private static final RateLimiter LOGGING_LIMITER = RateLimiter.create(1 / 60d);
private final CachingAttributeClient attributeClient;
private final AttributeProjectionRegistry attributeProjectionRegistry;

Expand All @@ -36,7 +41,7 @@ class DefaultValueResolver implements ValueResolver {
public Single<LiteralValue> resolve(
ValueSource valueSource, AttributeMetadata attributeMetadata) {
if (!attributeMetadata.hasDefinition()) {
return this.buildError("Attribute definition not set");
return this.buildAndLogErrorLazily("Attribute definition not set");
}

return this.resolveDefinition(
Expand Down Expand Up @@ -66,7 +71,7 @@ private Single<LiteralValue> resolveDefinition(
valueSource, attributeMetadata, definition.getFirstValuePresent());
case VALUE_NOT_SET:
default:
return this.buildError("Unrecognized attribute definition");
return this.buildAndLogErrorLazily("Unrecognized attribute definition");
}
}

Expand All @@ -88,7 +93,8 @@ private Single<LiteralValue> resolveValue(
Single<ValueSource> matchingValueSource =
Maybe.fromOptional(contextValueSource.sourceForScope(attributeScope))
.switchIfEmpty(
this.buildError("No value source available supporting scope %s", attributeScope));
this.buildAndLogErrorLazily(
"No value source available supporting scope %s", attributeScope));
switch (attributeType) {
case ATTRIBUTE:
return matchingValueSource
Expand All @@ -101,7 +107,7 @@ private Single<LiteralValue> resolveValue(
case UNRECOGNIZED:
case TYPE_UNDEFINED:
default:
return this.buildError("Unrecognized projection type");
return this.buildAndLogErrorLazily("Unrecognized projection type");
}
}

Expand All @@ -118,7 +124,7 @@ private Single<LiteralValue> resolveProjection(ValueSource valueSource, Projecti
return this.resolveExpression(valueSource, projection.getExpression());
case VALUE_NOT_SET:
default:
return this.buildError("Unrecognized projection type");
return this.buildAndLogErrorLazily("Unrecognized projection type");
}
}

Expand All @@ -145,7 +151,8 @@ private Single<LiteralValue> resolveExpression(
Single<AttributeProjection> projectionSingle =
Maybe.fromOptional(this.attributeProjectionRegistry.getProjection(expression.getOperator()))
.switchIfEmpty(
buildError("Unregistered projection operator: %s", expression.getOperator()));
buildAndLogErrorLazily(
"Unregistered projection operator: %s", expression.getOperator()));
Single<List<LiteralValue>> argumentsSingle =
this.resolveArgumentList(valueSource, expression.getArgumentsList());

Expand All @@ -159,7 +166,13 @@ private Single<List<LiteralValue>> resolveArgumentList(
.collect(Collectors.toList());
}

private <T> Single<T> buildError(String message, Object... args) {
return Single.error(new UnsupportedOperationException(String.format(message, args)));
private <T> Single<T> buildAndLogErrorLazily(String message, Object... args) {
return Single.error(
() -> {
if (LOGGING_LIMITER.tryAcquire()) {
log.error(String.format(message, args));
}
return new UnsupportedOperationException(String.format(message, args));
});
}
}