Skip to content

Conversation

@satish-mittal
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #245 (60adf83) into main (ce33ed7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #245   +/-   ##
=========================================
  Coverage     80.36%   80.36%           
  Complexity     1150     1150           
=========================================
  Files           101      101           
  Lines          4440     4440           
  Branches        415      415           
=========================================
  Hits           3568     3568           
  Misses          676      676           
  Partials        196      196           
Flag Coverage Δ
unit 80.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ertrace/core/spannormalizer/jaeger/SpanFilter.java 85.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce33ed7...60adf83. Read the comment docs.

@github-actions

This comment has been minimized.

@satish-mittal satish-mittal merged commit 5200907 into main Aug 4, 2021
@satish-mittal satish-mittal deleted the log_ratelimit_when_span_dropped branch August 4, 2021 13:02
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Unit Test Results

  69 files  ±0    69 suites  ±0   46s ⏱️ ±0s
365 tests ±0  365 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5200907. ± Comparison against base commit ce33ed7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants