Skip to content

fix: incorrect usage of metrics hashmap for late arrival counter #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022
Merged

fix: incorrect usage of metrics hashmap for late arrival counter #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...lizer/src/main/java/org/hypertrace/core/spannormalizer/jaeger/JaegerSpanPreProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ public class JaegerSpanPreProcessor
new ConcurrentHashMap<>();
private static final ConcurrentMap<String, Counter> tenantToSpansDroppedCount =
new ConcurrentHashMap<>();
private static final ConcurrentMap<String, Counter> tenantToLateArrivalSpansDroppedCount =
new ConcurrentHashMap<>();
private static final Duration minArrivalThreshold = Duration.of(30, ChronoUnit.SECONDS);
private TenantIdHandler tenantIdHandler;
private SpanFilter spanFilter;
Expand Down Expand Up @@ -138,7 +140,7 @@ PreProcessedSpan preProcessSpan(Span span) {
Duration.of(Math.abs(spanProcessedTime - spanStartTime), ChronoUnit.MILLIS);

if (spanStartTime > 0 && spanArrivalDelay.compareTo(lateArrivalThresholdDuration) > 0) {
tenantToSpansDroppedCount
tenantToLateArrivalSpansDroppedCount
.computeIfAbsent(
tenantId,
tenant ->
Expand Down