Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld requested a review from a team December 29, 2020 01:08
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #92 (4ca7a70) into main (05a6a27) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #92      +/-   ##
============================================
- Coverage     68.94%   68.63%   -0.32%     
+ Complexity      820      819       -1     
============================================
  Files            84       84              
  Lines          3475     3475              
  Branches        367      367              
============================================
- Hits           2396     2385      -11     
- Misses          935      946      +11     
  Partials        144      144              
Flag Coverage Δ Complexity Δ
unit 68.63% <ø> (-0.32%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...race/core/rawspansgrouper/TraceEmitPunctuator.java 69.56% <0.00%> (-15.95%) 8.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a6a27...4ca7a70. Read the comment docs.

default:
aliases:
- pinot-controller
- pinot-server
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up @kotharironak - the change in hypertrace/hypertrace-service#55 effects the tests in a bunch of repos. Not sure if there's more to find, but may be worth a search.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaron-steinfeld I had addressed this as part of this PR - #91, but, looks like it was not yet merged. I will scan other repos.

@aaron-steinfeld aaron-steinfeld merged commit 6ad02f4 into main Dec 29, 2020
@aaron-steinfeld aaron-steinfeld deleted the update-framework branch December 29, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants