Skip to content

chore: update view creator to fix multivalued col default #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2020
Merged

chore: update view creator to fix multivalued col default #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80d7d5
chore: update view creator to fix multivalued col default
aaron-steinfeld Dec 29, 2020
4ca7a70
chore: update test compose file
aaron-steinfeld Dec 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/hypertrace-ingester/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ services:
default:
aliases:
- pinot-controller
- pinot-server
Copy link
Contributor Author

@aaron-steinfeld aaron-steinfeld Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up @kotharironak - the change in hypertrace/hypertrace-service#55 effects the tests in a bunch of repos. Not sure if there's more to find, but may be worth a search.

Copy link
Contributor

@kotharironak kotharironak Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaron-steinfeld I had addressed this as part of this PR - #91, but, looks like it was not yet merged. I will scan other repos.

- pinot-broker
cpu_shares: 2048
depends_on:
kafka-zookeeper:
Expand Down
2 changes: 1 addition & 1 deletion hypertrace-ingester/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ dependencies {
implementation("org.hypertrace.core.serviceframework:platform-service-framework:0.1.9")
implementation("org.hypertrace.core.serviceframework:platform-metrics:0.1.8")
implementation("org.hypertrace.core.datamodel:data-model:0.1.12")
implementation("org.hypertrace.core.viewgenerator:view-generator-framework:0.1.14")
implementation("org.hypertrace.core.viewgenerator:view-generator-framework:0.1.21")
implementation("com.typesafe:config:1.4.0")

implementation(project(":span-normalizer:span-normalizer"))
Expand Down
2 changes: 1 addition & 1 deletion hypertrace-view-generator/hypertrace-view-creator/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ tasks.test {

dependencies {
implementation(project(":hypertrace-view-generator:hypertrace-view-generator-api"))
implementation("org.hypertrace.core.viewcreator:view-creator-framework:0.1.19")
implementation("org.hypertrace.core.viewcreator:view-creator-framework:0.1.21")
constraints {
implementation("com.google.guava:guava:30.0-jre") {
because("https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-1015415")
Expand Down
2 changes: 1 addition & 1 deletion hypertrace-view-generator/hypertrace-view-generator/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dependencies {
implementation(project(":hypertrace-view-generator:hypertrace-view-generator-api"))

// TODO: migrate in core
implementation("org.hypertrace.core.viewgenerator:view-generator-framework:0.1.19")
implementation("org.hypertrace.core.viewgenerator:view-generator-framework:0.1.21")
implementation("org.hypertrace.core.datamodel:data-model:0.1.12")
implementation("org.hypertrace.core.serviceframework:platform-metrics:0.1.18")

Expand Down