Skip to content

Conversation

@ravisingal
Copy link
Contributor

with hypertrace/kafka-streams-framework#26, span-normalizer and raw-spans-grouper pod does not require extra JMX exporter container.

@ravisingal ravisingal requested a review from a team December 30, 2020 12:26
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #94 (67a37c4) into main (05a6a27) will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #94      +/-   ##
============================================
- Coverage     68.94%   68.63%   -0.32%     
+ Complexity      820      819       -1     
============================================
  Files            84       84              
  Lines          3475     3475              
  Branches        367      367              
============================================
- Hits           2396     2385      -11     
- Misses          935      946      +11     
  Partials        144      144              
Flag Coverage Δ Complexity Δ
unit 68.63% <ø> (-0.32%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...race/core/rawspansgrouper/TraceEmitPunctuator.java 69.56% <0.00%> (-15.95%) 8.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e652fc0...6f98fe1. Read the comment docs.

@ravisingal ravisingal merged commit 15d3b04 into main Jan 4, 2021
@ravisingal ravisingal deleted the remove-jmx-exporter branch January 4, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants