Skip to content

Conversation

@ravisingal
Copy link
Contributor

Currently, we add an extra container in pod for exporting JMX metrics (see span-normalizer, raw-spans-grouper helm charts). With this change, kafka streams metrics will be available out of box on admin server pod along with other JVM metrics.

we can configure level of metrics using metrics.recording.level property: https://docs.confluent.io/platform/current/streams/monitoring.html#accessing-metrics-programmatically

@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #26 (e8cef6b) into main (be82b63) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #26      +/-   ##
============================================
- Coverage     62.45%   62.28%   -0.18%     
  Complexity       58       58              
============================================
  Files            15       15              
  Lines           285      289       +4     
  Branches         24       24              
============================================
+ Hits            178      180       +2     
- Misses           94       96       +2     
  Partials         13       13              
Impacted Files Coverage Δ Complexity Δ
...e/core/kafkastreams/framework/KafkaStreamsApp.java 57.14% <50.00%> (-0.36%) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be82b63...e8cef6b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants