Skip to content

feat(filter): expose a method #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2024
Merged

feat(filter): expose a method #2600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions projects/components/src/filtering/filter/filter-url.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,13 @@ export class FilterUrlService {
}

public setUrlFilters(filters: Filter[]): void {
this.navigationService.addQueryParametersToUrl({
this.navigationService.addQueryParametersToUrl(this.getQueryParamsObjectForFilters(filters));
}

public getQueryParamsObjectForFilters(filters: Filter[]): QueryParamObject {
Copy link
Contributor

@arjunlalb arjunlalb Jan 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public getQueryParamsObjectForFilters(filters: Filter[]): QueryParamObject {
public buildQueryParamsForFilters(filters: Filter[]): QueryParamObject {

nit: shorter name

return {
[FilterUrlService.FILTER_QUERY_PARAM]: filters.length === 0 ? undefined : filters.map(f => f.urlString),
});
};
}

public setUrlGroupBy(groupBy?: string[]): void {
Expand Down