Skip to content

feat: support for disabling a menu item #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2021
Merged

feat: support for disabling a menu item #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c7a660
feat: support for disabling a menu item
arjunlalb Jan 16, 2021
fc844f1
Merge branch 'main' into disable-menu-item
arjunlalb Jan 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions projects/components/src/menu-dropdown/menu-item/menu-item.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,9 @@

.menu-item {
@include popover-menu-item;

&.disabled {
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld Jan 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, we really should make this a global style

Copy link
Contributor Author

@arjunlalb arjunlalb Jan 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do that.

Copy link
Contributor Author

@arjunlalb arjunlalb Jan 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted to do that. but there are quite a few out there. some without the cursor change. So, need to audit all of them before doing a global change.

opacity: 0.4;
cursor: not-allowed;
}
}
20 changes: 20 additions & 0 deletions projects/components/src/menu-dropdown/menu-item/menu-item.component.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,24 @@ describe('Menu Item Component', () => {
expect(spectator.query(IconComponent)?.icon).toBe(IconType.MoreHorizontal);
expect(spectator.query(IconComponent)?.color).toBe(Color.Gray1);
}));

test('should disable menu item as expected', fakeAsync(() => {
const spectator = createHost(
'<ht-menu-item [icon]="icon" [label]="label" [iconColor]="iconColor" [disabled]="disabled"></ht-menu-item>',
{
hostProps: {
icon: IconType.MoreHorizontal,
label: 'Item',
iconColor: Color.Gray1,
disabled: true
}
}
);
expect(spectator.query('.menu-item')).toExist();
expect(spectator.query('.icon')).toExist();
expect(spectator.query('.label')).toHaveText('Item');
expect(spectator.query(IconComponent)?.icon).toBe(IconType.MoreHorizontal);
expect(spectator.query(IconComponent)?.color).toBe(Color.Gray1);
expect(spectator.query('.menu-item')?.classList.contains('disabled')).toBe(true);
}));
});
29 changes: 19 additions & 10 deletions projects/components/src/menu-dropdown/menu-item/menu-item.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,18 @@ import { IconSize } from '../../icon/icon-size';
selector: 'ht-menu-item',
changeDetection: ChangeDetectionStrategy.OnPush,
styleUrls: ['./menu-item.component.scss'],
template: `<div class="menu-item">
<ht-icon
class="icon"
*ngIf="this.icon"
[icon]="this.icon"
size="${IconSize.Small}"
[color]="this.iconColor"
></ht-icon>
<span class="label">{{ this.label }}</span>
</div>`
template: `<ht-event-blocker event="click" class="menu-item-container" [enabled]="this.disabled"
><div class="menu-item" [ngClass]="this.getStyleClasses()">
<ht-icon
class="icon"
*ngIf="this.icon"
[icon]="this.icon"
size="${IconSize.Small}"
[color]="this.iconColor"
></ht-icon>
<span class="label">{{ this.label }}</span>
</div></ht-event-blocker
>`
})
export class MenuItemComponent {
@Input()
Expand All @@ -26,4 +28,11 @@ export class MenuItemComponent {

@Input()
public iconColor?: string;

@Input()
public disabled?: boolean;

public getStyleClasses(): string[] {
return this.disabled ? ['disabled'] : [];
}
}