feat: adding all option and fixing some styling #514
Conversation
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 85.51% 85.52%
=======================================
Files 754 754
Lines 15490 15499 +9
Branches 1837 1838 +1
=======================================
+ Hits 13246 13255 +9
Misses 2213 2213
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| .multi-select-content { | ||
| @include dropdown(); | ||
| min-width: 120px; | ||
| max-height: 204px; |
There was a problem hiding this comment.
Shouldn't it have some max height? I'd rather it scroll then run off the screen.
There was a problem hiding this comment.
How do we choose this value? Different use cases may show different set of options. Do you want to expose an input for this?
There was a problem hiding this comment.
Or may be we can set a max height which is equal to available height, that is, from trigger element's position to the bottom on the window.
There was a problem hiding this comment.
Let me create a separate story for this change.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Description
Please include a summary of the change, motivation and context.
feat: adding "all" option and fixing some styling
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.