Skip to content

Conversation

@anandtiwary
Copy link
Contributor

@anandtiwary anandtiwary commented Jan 21, 2021

Description

Please include a summary of the change, motivation and context.
fix: adding debounce subscription on component init

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner January 21, 2021 18:49
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #519 (30b6ba7) into main (509c313) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
+ Coverage   85.52%   85.59%   +0.06%     
==========================================
  Files         754      754              
  Lines       15499    15504       +5     
  Branches     1838     1839       +1     
==========================================
+ Hits        13255    13270      +15     
+ Misses       2213     2203      -10     
  Partials       31       31              
Impacted Files Coverage Δ
.../components/src/search-box/search-box.component.ts 78.12% <100.00%> (+41.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 509c313...30b6ba7. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 16e2732 into main Jan 21, 2021
@anandtiwary anandtiwary deleted the fix-search branch January 21, 2021 21:00
@github-actions
Copy link

Unit Test Results

    4 files  ±0  232 suites  +1   13m 2s ⏱️ -4s
818 tests +2  818 ✔️ +2  0 💤 ±0  0 ❌ ±0 
822 runs  +2  822 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 16e2732. ± Comparison against base commit 509c313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants