ENG-9494 expose roles in request context #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
============================================
+ Coverage 71.49% 72.10% +0.61%
- Complexity 78 80 +2
============================================
Files 16 16
Lines 228 233 +5
Branches 12 13 +1
============================================
+ Hits 163 168 +5
+ Misses 55 54 -1
- Partials 10 11 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
surajpuvvada
previously approved these changes
Jun 11, 2021
surajpuvvada
left a comment
surajpuvvada
left a comment
There was a problem hiding this comment.
lgtm - but pls wait for one more review
grpc-context-utils/src/main/java/org/hypertrace/core/grpcutils/context/JwtParser.java
Outdated
Show resolved
Hide resolved
| private final String testJwtName = "Johnny Rocket"; | ||
| private final String testJwtPictureUrl = "www.example.com"; | ||
| private final String testJwtEmail = "jrocket@example.com"; | ||
| private final Set<String> testRoles = ImmutableSet.of("traceable", "user", "billing_admin"); |
Contributor
There was a problem hiding this comment.
We can drop the traceable role - want to leak as little as possible here
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@aaron-steinfeld addressed comments. Please have another look |
avinashkolluru
previously approved these changes
Jun 14, 2021
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
hey @aaron-steinfeld, addressed issues we discussed offline. Please have a look |
aaron-steinfeld
approved these changes
Jun 14, 2021
surajpuvvada
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add roles parsing logic to JWT parser and expose roles in request context.
The main motivation is to be able to reuse this logic in other parts of codebase, specifically in graphql context
Testing
Added unit tests
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.