refactor: add registry support for secure channels #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
requested review from
avinashkolluru,
surajpuvvada and
tim-mwangi
as code owners
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
============================================
+ Coverage 72.10% 72.42% +0.32%
- Complexity 80 85 +5
============================================
Files 16 16
Lines 233 243 +10
Branches 13 14 +1
============================================
+ Hits 168 176 +8
- Misses 54 55 +1
- Partials 11 12 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
pavan-traceable
previously approved these changes
Jul 7, 2021
Contributor
|
Thanks @aaron-steinfeld for taking this up. |
GurtejSohi
reviewed
Jul 7, 2021
| private final Map<String, ManagedChannel> channelMap = new ConcurrentHashMap<>(); | ||
| private volatile boolean isShutdown = false; | ||
|
|
||
| /** Use either {@link #forSecureAddress(String, int) or} */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** Use either {@link #forSecureAddress(String, int) or} */ | |
| /** Use either {@link #forSecureAddress(String, int)} or {@link #forPlaintextAddress(String, int)} */ |
Contributor
Author
There was a problem hiding this comment.
whoops, did I not finish writing that...
GurtejSohi
approved these changes
Jul 7, 2021
This comment has been minimized.
This comment has been minimized.
tim-mwangi
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add supports to the channel registry to create different plaintext and secure channels, differentiating the two.
Testing
Added UTs
Checklist: