Added parsing of binaryheaders in RequestContext#2
Merged
tim-mwangi merged 2 commits intomasterfrom Jul 21, 2020
Merged
Conversation
mohit-a21
requested review from
avinashkolluru,
buchi-busireddy,
surajpuvvada and
tim-mwangi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
============================================
+ Coverage 54.73% 57.84% +3.10%
- Complexity 23 25 +2
============================================
Files 9 9
Lines 95 102 +7
Branches 7 8 +1
============================================
+ Hits 52 59 +7
Misses 40 40
Partials 3 3
Continue to review full report at Codecov.
|
tim-mwangi
approved these changes
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the name of the header, if the header ends with
-binthen it is considered a binary header and a BINARY_BYTE_MARSHALLER is used in that case.