Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

We are working on being good grpc users, and part of that is fully shutting down our servers. In most places today we either don't shut down, or don't wait for shutdown to complete due to some confusion in the various shutdown APIs. This new util makes it easy for servers to shutdown correctly.

Testing

Added UT, also tested locally with a service.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #20 (aec0f66) into main (6f773e9) will decrease coverage by 0.07%.
The diff coverage is 72.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #20      +/-   ##
============================================
- Coverage     72.92%   72.84%   -0.08%     
- Complexity       94      101       +7     
============================================
  Files            16       17       +1     
  Lines           277      302      +25     
  Branches         17       20       +3     
============================================
+ Hits            202      220      +18     
- Misses           61       66       +5     
- Partials         14       16       +2     
Flag Coverage Δ
unit 72.84% <72.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce/core/grpcutils/server/ServerManagementUtil.java 72.00% <72.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f773e9...aec0f66. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 3a96620 into main Aug 25, 2021
@aaron-steinfeld aaron-steinfeld deleted the server-shutdown branch August 25, 2021 04:43
@github-actions
Copy link

Unit Test Results

12 files  +1  12 suites  +1   13s ⏱️ -1s
55 tests +2  55 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 3a96620. ± Comparison against base commit 6f773e9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants