Merged
Conversation
aaron-steinfeld
requested review from
saxenakshitiz,
surajpuvvada and
tim-mwangi
tim-mwangi
previously approved these changes
Oct 22, 2021
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
============================================
+ Coverage 72.44% 72.54% +0.09%
Complexity 101 101
============================================
Files 17 17
Lines 294 295 +1
Branches 21 21
============================================
+ Hits 213 214 +1
Misses 64 64
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
requested review from
JBAhire and
kotharironak
as code owners
This comment has been minimized.
This comment has been minimized.
JBAhire
approved these changes
Oct 22, 2021
tim-mwangi
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecating something that has long since been replaced (we just forgot to deprecate it, causing confusion).