Create 'otel.extension.library.version' attribute in all spans#371
Closed
bradAtTraceable wants to merge 2 commits intomainfrom
Closed
Create 'otel.extension.library.version' attribute in all spans#371bradAtTraceable wants to merge 2 commits intomainfrom
bradAtTraceable wants to merge 2 commits intomainfrom
Conversation
bradAtTraceable
requested review from
ryanericson,
shashank11p and
tim-mwangi
shashank11p
reviewed
Sep 9, 2022
Contributor
shashank11p
left a comment
shashank11p
left a comment
There was a problem hiding this comment.
We can maybe add this in https://github.com/hypertrace/javaagent/blob/main/otel-extensions/src/main/java/org/hypertrace/agent/otel/extensions/processor/AddTagsSpanProcessor.java#L39, so that we don't have to add it in every instrumentation framework, just at one place, and for any new frameworks in the future we do not need to remember and take care of adding this.
Contributor
Author
|
@shashank11p I'll give that a try. I didn't like the idea of making the changes in so many places, I was trying to instrument the OTEL code which set the otel.library.version attribute, but it proved to be impossible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the otel.library.version span attribute contains the OTEL version, rather than our version, this PR is introducing a new attribute: 'otel.extension.library.version', which will contain the version of the Hypertrace agent.