Skip to content

chore: exclude transitive dependency log4j-slf4j-impl#228

Merged
ravisingal merged 1 commit intomainfrom
exclude-log4j-slf4j
Sep 28, 2024
Merged

chore: exclude transitive dependency log4j-slf4j-impl#228
ravisingal merged 1 commit intomainfrom
exclude-log4j-slf4j

Conversation

@ravisingal
Copy link
Contributor

fixes:

Exception in thread "main" java.lang.NoSuchMethodError: 'void org.apache.logging.slf4j.Log4jLoggerFactory.<init>(org.apache.logging.slf4j.Log4jMarkerFactory)'
	at org.apache.logging.slf4j.SLF4JServiceProvider.initialize(SLF4JServiceProvider.java:57)
	at org.slf4j.LoggerFactory.bind(LoggerFactory.java:196)
	at org.slf4j.LoggerFactory.performInitialization(LoggerFactory.java:183)
	at org.slf4j.LoggerFactory.getProvider(LoggerFactory.java:486)
	at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:472)
	at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:421)
	at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:447)
	at org.hypertrace.core.serviceframework.PlatformServiceLauncher.<clinit>(PlatformServiceLauncher.java:14)

@ravisingal ravisingal requested a review from a team as a code owner September 28, 2024 06:42
@github-actions
Copy link

Test Results

325 tests  ±0   325 ✅ ±0   10s ⏱️ -1s
 42 suites ±0     0 💤 ±0 
 42 files   ±0     0 ❌ ±0 

Results for commit cf2a5bd. ± Comparison against base commit 08cb81d.

This pull request removes 72 and adds 13 tests. Note that renamed tests count towards both.
            long: 3600000
            valueType: LONG
          columnName: "SERVICE.startTime"
          long: 1570658506605
          long: 1727187787576
          long: 1727187789677
          long: 1727187790106
          long: 1727187808205
          long: 1727191387727
          long: 1727191389677
…
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [1] filter {
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "EVENT.spanTags"
      }
    }
    operator: CONTAINS_KEY
    rhs {
      literal {
        value {
          string: "span.kind"
        }
      }
    }
  }
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "EVENT.spanTags"
        subpath: "span.kind"
      }
    }
    operator: GE
    rhs {
      literal {
        value {
          string: "client"
        }
      }
    }
  }
}
selection {
  at…, 10, server
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [1] filter {
  childFilter {
    lhs {
      columnIdentifier {
        columnName: "API_TRACE.startTime"
      }
    }
    operator: GE
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727502523055
        }
      }
    }
  }
  childFilter {
    lhs {
      columnIdentifier {
        columnName: "API_TRACE.startTime"
      }
    }
    operator: LT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727506123188
        }
      }
    }
  }
  …
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [1] filter {
  childFilter {
    lhs {
      columnIdentifier {
        columnName: "BACKEND.startTime"
      }
    }
    operator: GE
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727502524969
        }
      }
    }
  }
  childFilter {
    lhs {
      columnIdentifier {
        columnName: "BACKEND.startTime"
      }
    }
    operator: LT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727506124969
        }
      }
    }
  }
  chil…
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [1] filter {
  childFilter {
    lhs {
      columnIdentifier {
        columnName: "SERVICE.startTime"
      }
    }
    operator: GE
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727502525287
        }
      }
    }
  }
  childFilter {
    lhs {
      columnIdentifier {
        columnName: "SERVICE.startTime"
      }
    }
    operator: LT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727506125288
        }
      }
    }
  }
  chil…
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [2] filter {
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "API_TRACE.startTime"
      }
    }
    operator: GE
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727502523055
        }
      }
    }
  }
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "API_TRACE.startTime"
      }
    }
    operator: LT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727506123188
        }
      }
  …
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [2] filter {
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "BACKEND.startTime"
      }
    }
    operator: GE
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727502524969
        }
      }
    }
  }
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "BACKEND.startTime"
      }
    }
    operator: LT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727506124969
        }
      }
    }
…
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [2] filter {
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "EVENT.startTime"
      }
    }
    operator: GT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1570658506605
        }
      }
    }
  }
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "EVENT.startTime"
      }
    }
    operator: LT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 2570744906673
        }
      }
    }
  }
…, 2, server
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [2] filter {
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "SERVICE.startTime"
      }
    }
    operator: GE
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727502525287
        }
      }
    }
  }
  childFilter {
    lhs {
      attribute_expression {
        attributeId: "SERVICE.startTime"
      }
    }
    operator: LT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727506125288
        }
      }
    }
…
org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest ‑ [3] selection {
  function {
    functionName: "sum"
    arguments {
      attribute_expression {
        attributeId: "EVENT.spanTags"
        subpath: "otel.status_code"
      }
    }
  }
}
, 1, 0.0
org.hypertrace.core.query.service.htqueries.HTPostgresQueriesTest ‑ [1] filter {
  childFilter {
    lhs {
      columnIdentifier {
        columnName: "SERVICE.startTime"
      }
    }
    operator: GE
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727502542353
        }
      }
    }
  }
  childFilter {
    lhs {
      columnIdentifier {
        columnName: "SERVICE.startTime"
      }
    }
    operator: LT
    rhs {
      literal {
        value {
          valueType: LONG
          long: 1727506142354
        }
      }
    }
  }
  chil…
…

// We want to use log4j2 impl so exclude the log4j binding of slf4j
exclude("org.slf4j", "slf4j-log4j12")
exclude("log4j", "log4j")
exclude("org.apache.logging.log4j", "log4j-slf4j-impl")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinot never ceases to amaze me..

@ravisingal ravisingal merged commit e092fbf into main Sep 28, 2024
@ravisingal ravisingal deleted the exclude-log4j-slf4j branch September 28, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants