chore: expose hybrid service framework #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-mwangi
previously approved these changes
Jan 6, 2025
tim-mwangi
previously approved these changes
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
=========================================
Coverage 68.53% 68.53%
Complexity 107 107
=========================================
Files 17 17
Lines 623 623
Branches 32 32
=========================================
Hits 427 427
Misses 177 177
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tim-mwangi
approved these changes
Jan 6, 2025
aaron-steinfeld
commented
Jan 6, 2025
| return List.of(); | ||
| } | ||
|
|
||
| protected List<HybridHttpHandlerFactory> getHybridHttpHandlerFactories() { |
There was a problem hiding this comment.
The extra interface is a variant of the existing HttpHandlerFactory that gives the construction context access to the GRPC environment as well. The handlers the factory returns are no different, but these extra arguments are only available to hybrid containers. This is typically used for an HTTP handler to then turn around and make a call to the GRPC container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have various hybrid grpc/http services that have some version of this PR in their local codebase. Moving it to central location.