-
Notifications
You must be signed in to change notification settings - Fork 1
fix: test cleanup #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
=========================================
Coverage 70.57% 70.57%
Complexity 106 106
=========================================
Files 15 15
Lines 588 588
Branches 32 32
=========================================
Hits 415 415
Misses 154 154
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| id("org.hypertrace.jacoco-report-plugin") version "0.2.0" apply false | ||
| id("org.hypertrace.code-style-plugin") version "1.1.2" apply false | ||
| id("org.owasp.dependencycheck") version "8.2.1" | ||
| id("org.owasp.dependencycheck") version "8.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to be careful with this one. It introduces a subtle issue that requires a gradle version upgrade.
Description
Fixed a few issues that came up when debugging an integration test shutdown. Shutdown was called an excessive number of times:
IntegrationTestServiceLauncher.shutdown()for every running service, but shutdown() already loops through all services.