Skip to content

refactor: update http framework to provide inprocess grpc reg #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2023
Merged

refactor: update http framework to provide inprocess grpc reg #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ork/src/main/java/org/hypertrace/core/serviceframework/http/HttpContainerEnvironment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
package org.hypertrace.core.serviceframework.http;

import com.typesafe.config.Config;
import org.hypertrace.core.grpcutils.client.GrpcChannelRegistry;
import org.hypertrace.core.grpcutils.client.InProcessGrpcChannelRegistry;
import org.hypertrace.core.serviceframework.spi.PlatformServiceLifecycle;

public interface HttpContainerEnvironment {
GrpcChannelRegistry getChannelRegistry();
InProcessGrpcChannelRegistry getChannelRegistry();

Config getConfig(String serviceName);

Expand Down
4 changes: 2 additions & 2 deletions ...in/java/org/hypertrace/core/serviceframework/http/StandAloneHttpContainerEnvironment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
import com.typesafe.config.Config;
import lombok.AllArgsConstructor;
import lombok.Getter;
import org.hypertrace.core.grpcutils.client.GrpcChannelRegistry;
import org.hypertrace.core.grpcutils.client.InProcessGrpcChannelRegistry;
import org.hypertrace.core.serviceframework.config.ConfigClient;
import org.hypertrace.core.serviceframework.spi.PlatformServiceLifecycle;

@AllArgsConstructor
public class StandAloneHttpContainerEnvironment implements HttpContainerEnvironment {
@Getter private final GrpcChannelRegistry channelRegistry;
@Getter private final InProcessGrpcChannelRegistry channelRegistry;
@Getter private final PlatformServiceLifecycle lifecycle;
private final ConfigClient configClient;

Expand Down
6 changes: 3 additions & 3 deletions ...ava/org/hypertrace/core/serviceframework/http/StandAloneHttpPlatformServiceContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import java.util.List;
import java.util.stream.Collectors;
import lombok.extern.slf4j.Slf4j;
import org.hypertrace.core.grpcutils.client.GrpcChannelRegistry;
import org.hypertrace.core.grpcutils.client.GrpcRegistryConfig;
import org.hypertrace.core.grpcutils.client.InProcessGrpcChannelRegistry;
import org.hypertrace.core.serviceframework.PlatformService;
import org.hypertrace.core.serviceframework.config.ConfigClient;
import org.hypertrace.core.serviceframework.http.jetty.JettyHttpServerBuilder;
Expand All @@ -17,12 +17,12 @@
@Slf4j
public abstract class StandAloneHttpPlatformServiceContainer extends PlatformService {
private HttpContainer container;
private final GrpcChannelRegistry grpcChannelRegistry;
private final InProcessGrpcChannelRegistry grpcChannelRegistry;

public StandAloneHttpPlatformServiceContainer(ConfigClient config) {
super(config);
grpcChannelRegistry =
new GrpcChannelRegistry(
new InProcessGrpcChannelRegistry(
GrpcRegistryConfig.builder()
.defaultInterceptor(
new MetricCollectingClientInterceptor(
Expand Down