Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

Description

This new interceptor verifies that clients are adding timeouts. It is lenient and logs a warning but does not block a request if missing a timeout.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner May 31, 2024 14:04
@github-actions
Copy link

github-actions bot commented May 31, 2024

Test Results

32 tests  ±0   32 ✅ ±0   8s ⏱️ ±0s
 9 suites ±0    0 💤 ±0 
 9 files   ±0    0 ❌ ±0 

Results for commit c320687. ± Comparison against base commit 1ccb3bb.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (1ccb3bb) to head (c320687).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #98   +/-   ##
=========================================
  Coverage     67.25%   67.25%           
  Complexity      107      107           
=========================================
  Files            17       17           
  Lines           620      620           
  Branches         32       32           
=========================================
  Hits            417      417           
  Misses          184      184           
  Partials         19       19           
Flag Coverage Δ
unit 67.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tim-mwangi
tim-mwangi previously approved these changes May 31, 2024
@aaron-steinfeld aaron-steinfeld merged commit 1916b85 into main May 31, 2024
@aaron-steinfeld aaron-steinfeld deleted the update-interceptors branch May 31, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants