HW-52045 ui editability configuration #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateWidget.java
Outdated
Show resolved
Hide resolved
peter-joseph
changed the base branch from
feature/HW-52170-key-and-field-gql-integration
to
task/HW-52170-key-and-field-gql-integration
added 3 commits
May 15, 2019 16:20
…eld-gql-integration' into task/HW-52045-ui-editability-configuration
fmattos-hw
requested changes
May 17, 2019
ui/src/main/java/com/hyperwallet/android/ui/view/widget/SelectionWidget.java
Show resolved
Hide resolved
| showSelectionFragmentDialog(); | ||
| } | ||
| }); | ||
| if (mField.isEditable()) { |
Collaborator
There was a problem hiding this comment.
I wonder if we should also not register listeners to the other widgets
Collaborator
Author
There was a problem hiding this comment.
I think we will just make sure that mEditText.setEnabled(false); then the editText will not do all those action callbacks
added 7 commits
May 16, 2019 17:53
* added preset values on widgets * widget-alignment-refactor * finalized margin
…eld-gql-integration' into task/HW-52045-ui-editability-configuration
fmattos-hw
approved these changes
May 21, 2019
Collaborator
fmattos-hw
left a comment
fmattos-hw
left a comment
There was a problem hiding this comment.
PR looks good to me. Please make sure all the reviewers are happy with it too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.