Dtserwfour 170 remaining screen updates #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdamodarannair
requested review from
rajkumar-balakrishnasamy and
shanavas123
pdamodarannair
requested review from
ShravanKumarSidigum,
malaw-hw and
vwagh-hw
vwagh-hw
previously approved these changes
Nov 18, 2020
Collaborator
vwagh-hw
left a comment
vwagh-hw
left a comment
There was a problem hiding this comment.
LGTM but please verify that all Automation tests pass as well
shanavas123
previously approved these changes
Nov 19, 2020
rajkumar-balakrishnasamy
previously approved these changes
Nov 19, 2020
pdamodarannair
dismissed stale reviews from rajkumar-balakrishnasamy, shanavas123, and vwagh-hw
via
7dda117
vwagh-hw
previously approved these changes
Nov 20, 2020
shanavas123
previously approved these changes
Nov 23, 2020
…elopment' of https://github.com/hyperwallet/hyperwallet-android-ui-sdk into bug/DTSERWFOUR-170-Remaining-Screen-Updates � Conflicts: � transferui/src/main/res/values-es/strings.xml
shanavas123
previously approved these changes
Nov 23, 2020
rajkumar-balakrishnasamy
previously approved these changes
Nov 23, 2020
…/github.com/hyperwallet/hyperwallet-android-ui-sdk into bug/DTSERWFOUR-170-Remaining-Screen-Updates
shanavas123
dismissed stale reviews from rajkumar-balakrishnasamy and themself
via
2a17ee4
shanavas123
previously approved these changes
Nov 24, 2020
shanavas123
previously approved these changes
Nov 25, 2020
shanavas123
previously approved these changes
Nov 25, 2020
vwagh-hw
reviewed
Nov 25, 2020
commonui/src/test/java/com/hyperwallet/android/ui/common/util/CurrencyParserTest.java
Outdated
Show resolved
Hide resolved
commonui/src/test/java/com/hyperwallet/android/ui/common/util/CurrencyParserTest.java
Outdated
Show resolved
Hide resolved
vwagh-hw
reviewed
Nov 25, 2020
commonui/src/test/java/com/hyperwallet/android/ui/common/util/CurrencyParserTest.java
Outdated
Show resolved
Hide resolved
vwagh-hw
approved these changes
Nov 25, 2020
malaw-hw
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.