Skip to content

DTSERWFOUR-382-android-transaction-list-is -not-loaded #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2021
Merged

DTSERWFOUR-382-android-transaction-list-is -not-loaded #245

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99901cf
DTSERWFOUR-382-android-transaction-list-is -not-loaded
shanavas123 Feb 19, 2021
3452d99
update project version
shanavas123 Feb 20, 2021
1f3112c
Merge branch 'development' into bug/DTSERWFOUR-382-android-transactio…
malaw-hw Feb 22, 2021
45b8c9f
Merge branch 'development' into bug/DTSERWFOUR-382-android-transactio…
malaw-hw Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions receiptui/src/main/java/com/hyperwallet/android/ui/receipt/view/ListReceiptsFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public class ListReceiptsFragment extends Fragment {
private View mProgressBar;
private View mEmptyTransactionPlaceholder;
private TextView mEmptyTransactionTextView;
private Boolean mShouldShowNoTransactionPlaceholder = Boolean.TRUE;
private Boolean mShouldShowNoTransactionPlaceholder = Boolean.FALSE;
private ListReceiptsFragmentCallback callback;

static ListReceiptsFragment newInstance() {
Expand Down Expand Up @@ -164,20 +164,6 @@ private void registerObservers() {
@Override
public void onChanged(final PagedList<Receipt> receipts) {
mListReceiptsAdapter.submitList(receipts);
receipts.addWeakCallback(null, new PagedList.Callback() {
@Override
public void onChanged(int position, int count) {
}

@Override
public void onInserted(int position, int count) {
mShouldShowNoTransactionPlaceholder = (receipts.size() > 0) ? Boolean.FALSE : Boolean.TRUE;
}

@Override
public void onRemoved(int position, int count) {
}
});
}
});

Expand All @@ -189,6 +175,7 @@ public void onChanged(Boolean loading) {
mProgressBar.setVisibility(View.VISIBLE);
} else {
mProgressBar.setVisibility(View.GONE);
mShouldShowNoTransactionPlaceholder = (Objects.requireNonNull(mReceiptViewModel.receipts().getValue()).size() > 0) ? Boolean.FALSE : Boolean.TRUE;
if (mShouldShowNoTransactionPlaceholder) {
if (mReceiptViewModel instanceof ListUserReceiptsViewModel) {
mEmptyTransactionTextView.setText(R.string.mobileNoTransactionsUser);
Expand Down