DTSERWFOUR-387-edit-venmo account partial edit is not successful #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malaw-hw
requested changes
Feb 19, 2021
malaw-hw
previously approved these changes
Feb 22, 2021
…-partial-edit-is-not-successful
pdamodarannair
previously approved these changes
Feb 24, 2021
…-partial-edit-is-not-successful
vwagh-hw
reviewed
Feb 26, 2021
...ui/src/main/java/com/hyperwallet/android/ui/transfermethod/view/widget/ExpiryDateWidget.java
Outdated
Show resolved
Hide resolved
...thodui/src/main/java/com/hyperwallet/android/ui/transfermethod/view/widget/NumberWidget.java
Outdated
Show resolved
Hide resolved
...ethodui/src/main/java/com/hyperwallet/android/ui/transfermethod/view/widget/PhoneWidget.java
Outdated
Show resolved
Hide resolved
...methodui/src/main/java/com/hyperwallet/android/ui/transfermethod/view/widget/TextWidget.java
Outdated
Show resolved
Hide resolved
…-partial-edit-is-not-successful
…ot-successful' of https://github.com/hyperwallet/hyperwallet-android-ui-sdk into bug/DTSERWFOUR-387-edit-venmo-account-partial-edit-is-not-successful
shanavas123
dismissed stale reviews from pdamodarannair and malaw-hw
via
650f475
vwagh-hw
reviewed
Feb 27, 2021
Collaborator
vwagh-hw
left a comment
vwagh-hw
left a comment
There was a problem hiding this comment.
Code has changed a lot, this should be tested again @SaiNarendran
...in/java/com/hyperwallet/android/ui/transfermethod/view/widget/AbstractMaskedInputWidget.java
Outdated
Show resolved
Hide resolved
...in/java/com/hyperwallet/android/ui/transfermethod/view/widget/AbstractMaskedInputWidget.java
Outdated
Show resolved
Hide resolved
...ui/src/main/java/com/hyperwallet/android/ui/transfermethod/view/widget/ExpiryDateWidget.java
Outdated
Show resolved
Hide resolved
@vwagh-hw - QA has completed another round of validation and it looks fine. |
vwagh-hw
approved these changes
Mar 2, 2021
pdamodarannair
approved these changes
Mar 2, 2021
SaiNarendran
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.