HW-52174. Added datePicker for DateWidget #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/HW-52169-gql-version-two-integration
…e/HW-52169-gql-version-two-integration
azakrevska-epam
requested review from
fmattos-hw,
peter-joseph,
skoong and
vshcherbyna-epam
peter-joseph
requested changes
May 22, 2019
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateWidget.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/transfermethod/AddTransferMethodFragment.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/transfermethod/AddTransferMethodFragment.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateUtil.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateUtil.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateUtil.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateUtil.java
Outdated
Show resolved
Hide resolved
azakrevska-epam
changed the base branch from
epic/HW-52169-gql-version-two-integration
to
development
azakrevska-epam
changed the base branch from
development
to
epic/HW-52169-gql-version-two-integration
azakrevska-epam
changed the base branch from
epic/HW-52169-gql-version-two-integration
to
development
peter-joseph
requested changes
May 23, 2019
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateDialogFragment.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/transfermethod/AddTransferMethodActivity.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateDialogFragment.java
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateParseException.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateDialogFragment.java
Outdated
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateDialogFragment.java
Outdated
Show resolved
Hide resolved
peter-joseph
previously approved these changes
May 23, 2019
Collaborator
There was a problem hiding this comment.
LGTMN 👍, please coordinate with @skoong @fmattos-hw for additional approval
Moreover IDK if we can merge directly to development with a task prefixed branch
fmattos-hw
requested changes
May 24, 2019
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateUtil.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,16 @@ | |||
| package com.hyperwallet.android.ui.view.widget; | |||
|
|
|||
| class DateParseException extends Exception { | |||
Collaborator
There was a problem hiding this comment.
We actually don't need this class because of the way we handle the exception in WidgetDateDialogFragment$onCreateDialog. We can let the parse exception bubble up
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateUtil.java
Outdated
Show resolved
Hide resolved
ui/src/test/java/com/hyperwallet/android/ui/view/widget/DateUtilTest.java
Show resolved
Hide resolved
ui/src/main/java/com/hyperwallet/android/ui/view/widget/DateUtil.java
Outdated
Show resolved
Hide resolved
fmattos-hw
approved these changes
May 27, 2019
peter-joseph
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new branch and PR due to problems with rebase and merged parent branches