DTSERWFOUR-463-Allow Transaction Details text to be selected #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanavas123
requested review from
SaiNarendran,
aparthibanpaypal,
rbanikPP and
vwagh-hw
rbanikPP
reviewed
Mar 23, 2021
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@+id/transaction_title" /> | ||
|
|
Contributor
Author
There was a problem hiding this comment.
<include layout="@layout/receipt" /> common for recent receipt, transaction list.
Collaborator
There was a problem hiding this comment.
can you explain why <include layout="@layout/receipt" /> had to be deleted and replaced with 100 lines
Contributor
Author
There was a problem hiding this comment.
is common for home recent recipe list and transaction recipe list ,while implement the text selection its reflect in home and transaction list.
Contributor
Author
There was a problem hiding this comment.
revert the <include layout="@layout/receipt" /> text selection added in code
rbanikPP
approved these changes
Mar 23, 2021
vwagh-hw
approved these changes
Mar 29, 2021
vwagh-hw
pushed a commit
that referenced
this pull request
Mar 30, 2021
* DTSERWFOUR-463-Allow Transaction Details text to be selected (#254) * DTSERWFOUR-463-Allow Transaction Details text to be selected * Address review comments * Address review comments * UIcase for Allow Transaction details text to be selected Co-authored-by: Naren <najayaraman@paypal.com> * DTSERWFOUR-461-Update decimal places for FX (#253) * DTSERWFOUR-461-Update decimal places for FX * address review comments * address review comments * update unit test. * Address review comments * Address review comments * Address review comments * Fix info overlap on smaller screens. * Fix info overlap on smaller screens. Co-authored-by: Naren <najayaraman@paypal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.