HW-53053. Split ui modules #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azakrevska-epam
requested review from
fmattos-hw,
peter-joseph,
skoong and
vshcherbyna-epam
fmattos-hw
requested changes
May 28, 2019
Collaborator
fmattos-hw
left a comment
fmattos-hw
left a comment
There was a problem hiding this comment.
Please look at the dependencies being used by multiple sub-projects and add variables for them, i.e material design dependency. Also try to find a way to set the correct group id when adding a project as dependency i.e api project(':common')
Collaborator
|
@azakrevska-epam I really liked the re-organization using the android library gradle file! |
peter-joseph
requested changes
May 28, 2019
Collaborator
There was a problem hiding this comment.
Nice job @azakrevska-epam on Splitting can we also move the following from [ui module]to [common module]?
- res/drawable/*
- res/font/*
- res/values/colors.xml
- res/values/dimens.xml
- res/values/styles.xml
Thanks in advance!
peter-joseph
requested changes
May 30, 2019
Collaborator
peter-joseph
left a comment
peter-joseph
left a comment
There was a problem hiding this comment.
@azakrevska-epam Can't build UI module because of the ff:
- error on overdraw, I don't have a clue
/Users/${user}/workspace/hw-android-sdk-public/hyperwallet-android-ui-sdk/ui/src/main/res/layout/item_widget_section_header.xml:6: Error: Possible overdraw: Root element paints background @drawable/view_border_top_bottom with a theme that also paints a background (inferred theme is @android:style/Theme.Holo) [Overdraw]
android:background="@drawable/view_border_top_bottom"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- cannot find
Widget_Hyperwallet_DatePickertheme
Author
|
@peter-joseph Thank you, fixed styles and added exceptions to the lint file |
fmattos-hw
previously approved these changes
Jun 4, 2019
azakrevska-epam
dismissed stale reviews from fmattos-hw and peter-joseph
via
7c6b5d9
peter-joseph
previously approved these changes
Jun 4, 2019
fmattos-hw
previously approved these changes
Jun 4, 2019
fmattos-hw
approved these changes
Jun 4, 2019
peter-joseph
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.