HW-53401. Added ui tests for list receipts #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azakrevska-epam
requested review from
fmattos-hw,
peter-joseph,
skoong and
vshcherbyna-epam
skoong
requested changes
Jun 6, 2019
ui/src/androidTest/java/com/hyperwallet/android/transfermethod/ui/ListReceiptsTest.java
Outdated
Show resolved
Hide resolved
ui/src/androidTest/java/com/hyperwallet/android/transfermethod/ui/ListReceiptsTest.java
Outdated
Show resolved
Hide resolved
ui/src/androidTest/java/com/hyperwallet/android/transfermethod/ui/ListReceiptsTest.java
Outdated
Show resolved
Hide resolved
ui/src/androidTest/java/com/hyperwallet/android/transfermethod/ui/ListReceiptsTest.java
Outdated
Show resolved
Hide resolved
peter-joseph
reviewed
Jun 7, 2019
ui/src/androidTest/java/com/hyperwallet/android/transfermethod/ui/ListReceiptsTest.java
Show resolved
Hide resolved
skoong
approved these changes
Jun 10, 2019
fmattos-hw
reviewed
Jun 10, 2019
| } | ||
|
|
||
| @Test | ||
| public void testListReceipts_userHasMultipleTransactions() { |
Collaborator
There was a problem hiding this comment.
I think we need to add a use case where there's a new transaction type which is not mapped in our transaction types and whatever default value should be displayed
vshcherbyna-epam
approved these changes
Jun 11, 2019
peter-joseph
approved these changes
Jun 11, 2019
fmattos-hw
reviewed
Jun 11, 2019
| onView(withId(R.id.toolbar)).check(matches(isDisplayed())); | ||
| onView(allOf(instanceOf(TextView.class), withParent(withId(R.id.toolbar)))) | ||
| .check(matches(withText(R.string.title_activity_receipt_list))); | ||
| //todo: check empty view when it will be ready |
Author
There was a problem hiding this comment.
@fmattos-hw this todo is addressed to @peter-joseph - if I'm not mistaken - there should be a view for empty list (like label: you don't have transactions... etc.) in the Fragment
fmattos-hw
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.