HW-53765. renamed *Util to *Utils #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azakrevska-epam
requested review from
fmattos-hw,
peter-joseph,
skoong and
vshcherbyna-epam
| * Class is used for manage and convert date {@link DateWidget} | ||
| */ | ||
| public final class DateUtil { | ||
| public final class DateUtils { |
Collaborator
There was a problem hiding this comment.
Sorry I forgot we have this, DateUtil class in ui module, @azakrevska-epam @fmattos-hw there's also a DateUtils class in com.hyperwallet.android.ui.common.util.DateUtils does it make sense to merge them into one?
Collaborator
There was a problem hiding this comment.
I think the class com.hyperwallet.android.ui.view.widget.DateUtils should not exist and all methods should be moved to the DateWidget class. I don't like the idea of having util class with state (date format instance created in the constructor) and public constructor, but based on our conversation, we can leave it as is and use android date formatting
fmattos-hw
approved these changes
Jun 18, 2019
peter-joseph
approved these changes
Jun 18, 2019
vshcherbyna-epam
pushed a commit
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.