Skip to content

Conversation

@azakrevska-epam
Copy link

Renamed

Copy link
Collaborator

@fmattos-hw fmattos-hw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, just be advised we're planning on merging the ppc receipt list before this pr, so some of the view model classes will have a different name

@skoong
Copy link
Collaborator

skoong commented Jul 5, 2019

@azakrevska-epam looks like its failing code coverage now. Also I reverted the change for gradle upgrade as the artifacts do not build correctly on 3.4.1.

> Task :receipt:jacocoTestCoverageVerification FAILED
[ant:jacocoReport] Rule violated for class com.hyperwallet.android.ui.receipt.repository.UserReceiptRepositoryImpl: branches covered ratio is 0.00, but expected minimum is 0.65
[ant:jacocoReport] Rule violated for class com.hyperwallet.android.ui.receipt.repository.PrepaidCardReceiptRepositoryImpl: branches covered ratio is 0.00, but expected minimum is 0.65
[ant:jacocoReport] Rule violated for class com.hyperwallet.android.ui.receipt.repository.PrepaidCardReceiptDataSource: branches covered ratio is 0.60, but expected minimum is 0.65

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':receipt:jacocoTestCoverageVerification'.
> Rule violated for class com.hyperwallet.android.ui.receipt.repository.UserReceiptRepositoryImpl: branches covered ratio is 0.00, but expected minimum is 0.65
  Rule violated for class com.hyperwallet.android.ui.receipt.repository.PrepaidCardReceiptRepositoryImpl: branches covered ratio is 0.00, but expected minimum is 0.65
  Rule violated for class com.hyperwallet.android.ui.receipt.repository.PrepaidCardReceiptDataSource: branches covered ratio is 0.60, but expected minimum is 0.65

@skoong skoong merged commit 3aa8829 into development Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants