Skip to content

HW-50653: SDK - TypeError thrown when response status is 204 No Content#17

Merged
wmews-hw merged 1 commit into
masterfrom
feature/HW-50653-SDK-TypeError-thrown-when-response-status-is-204-No-Content
Apr 12, 2019
Merged

HW-50653: SDK - TypeError thrown when response status is 204 No Content#17
wmews-hw merged 1 commit into
masterfrom
feature/HW-50653-SDK-TypeError-thrown-when-response-status-is-204-No-Content

Conversation

@aseveryn-hw
Copy link
Copy Markdown
Contributor

No description provided.

@aseveryn-hw aseveryn-hw self-assigned this Apr 9, 2019
@aseveryn-hw aseveryn-hw requested a review from wmews-hw April 9, 2019 16:58
Copy link
Copy Markdown

@vkorotchenko vkorotchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

encryptedMessage = encryption.encrypt(json.dumps(data))

session_mock.return_value = mock.MagicMock(
status_code=204,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know if we have style guide for python, but we should keep it consistent through the code(spacing before/after equals).

@wmews-hw wmews-hw merged commit ecfc24a into master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants