Feature/hw 58097 v3 python sdk for transfer refunds#36
Conversation
Rrathinasabapath
left a comment
Rrathinasabapath
left a comment
There was a problem hiding this comment.
Please make necessary changes
| ''' | ||
|
|
||
| @mock.patch('hyperwallet.utils.ApiClient._makeRequest') | ||
| def test_transfer_refunds_success(self, mock_post): |
There was a problem hiding this comment.
Please follow the convention of method names. This should be test_create_transfer_refund_successful. Dont forget to have the type of operation(Create/get/list/update) mentioned in the method's name.
There was a problem hiding this comment.
method name has been changed.
| Upload Documents | ||
|
|
||
| ''' | ||
| def test_uploadDocumentsForUser_fail_need_user_token(self): |
There was a problem hiding this comment.
It looks like that you added this method. Pls check. this doesn't look related to transfer refund.
There was a problem hiding this comment.
v3 merged code
| response = self.api.createTransferRefund('token',self.data) | ||
| self.assertTrue(response.token, self.data.get('token')) | ||
|
|
||
| def test_transfer_refunds_fail_need_payment_token(self): |
There was a problem hiding this comment.
Please follow the convention of method names. This should be test_create_transfer_refund.... Dont forget to have the type of operation(Create/get/list/update) mentioned in the method's name.
There was a problem hiding this comment.
method name has been changed.
|
|
||
| self.assertEqual(exc.exception.message, 'transferToken is required') | ||
|
|
||
| def test_transfer_refunds_fail_need_data(self): |
There was a problem hiding this comment.
Please follow the convention of method names. This should be test_create_transfer_refunds.... Dont forget to have the type of operation(Create/get/list/update) mentioned in the method's name.
There was a problem hiding this comment.
method name has been changed.
|
|
||
| ''' | ||
|
|
||
| def test_transfer_spend_back_refunds_user_token(self): |
There was a problem hiding this comment.
Please follow the convention of method names. This should be test_create_transfer_spend.... Dont forget to have the type of operation(Create/get/list/update) mentioned in the method's name.
There was a problem hiding this comment.
method name has been changed.
| def __buildUrl(self, *paths): | ||
| return '/'.join(s.strip('/') for s in paths) | ||
|
|
||
| def uploadDocumentsForUser(self, |
There was a problem hiding this comment.
It looks like you have added this method. Pls check if there is any code duplication and find out why its appearing so.
There was a problem hiding this comment.
v3 merged code
|
|
||
| return (data if data is None else self.encryption.encrypt(data)) if self.encrypted else data | ||
|
|
||
| def putDocument(self, partialUrl, data, files): |
There was a problem hiding this comment.
Please verify if the method has been added by you or if there is any duplication.
There was a problem hiding this comment.
v3 merged code
|
Please change the "branch to merge into" to V3 (not master). |
Rrathinasabapath
left a comment
Rrathinasabapath
left a comment
There was a problem hiding this comment.
Reviewed changes. They can be reviewed by Peter.
|
Madhan, the 'foreignExchanges' part need to be added to this. |
5 participants
Changes has been done for transfer refunds