Added transfers and paypal accounts endpoints#9
Merged
gmeyer-hw merged 4 commits intohyperwallet:masterfrom Oct 19, 2018
Merged
Added transfers and paypal accounts endpoints#9gmeyer-hw merged 4 commits intohyperwallet:masterfrom
gmeyer-hw merged 4 commits intohyperwallet:masterfrom
Conversation
gmeyer-hw
reviewed
Aug 23, 2018
| ''' | ||
|
|
||
| def createTransfer(self, | ||
| data=None): |
Contributor
There was a problem hiding this comment.
I cloned this project and after I execute this command Make test then I faced some code style warning like this: _hyperwallet/api.py:1461:26: E127 continuation line over-indented for visual indent ... _
gmeyer-hw
reviewed
Aug 23, 2018
|
|
||
| ''' | ||
|
|
||
| Transfers |
Contributor
There was a problem hiding this comment.
if you run make coverage then you can face some errors like this:
======================================================================
ERROR: test_failed_connection (hyperwallet.tests.test_client.ApiClientTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/gmeyer/IntellijWorkspace/python-sdk-aseveryn-epam/hyperwallet/tests/test_client.py", line 19, in setUp
SERVER
TypeError: __init__() takes exactly 5 arguments (4 given)
======================================================================
ERROR: test_receive_non_json_response (hyperwallet.tests.test_client.ApiClientTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/gmeyer/IntellijWorkspace/python-sdk-aseveryn-epam/hyperwallet/tests/test_client.py", line 19, in setUp
SERVER
TypeError: __init__() takes exactly 5 arguments (4 given)'
Contributor
Author
There was a problem hiding this comment.
In scope of this pull request there were no changes in apiclient constructor, but in pull request "Layer 7 encryption" number of arguments in apiclient constructor had been changed, so it seems you have an intersection of those two pull requests. Please check it again
gmeyer-hw
suggested changes
Oct 5, 2018
Contributor
gmeyer-hw
left a comment
gmeyer-hw
left a comment
There was a problem hiding this comment.
Please have a look on PR review comments
aseveryn-epam
force-pushed
the
transfers-and-paypal-accounts
branch
from
cbd5c71 to
64c6476
Compare
aseveryn-epam
force-pushed
the
transfers-and-paypal-accounts
branch
from
e0ff8a0 to
485b599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.