Dw/default sources #836
Closed
Dw/default sources #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick1udwig
reviewed
Aug 28, 2025
| drive_path: drive_path.to_string(), | ||
| is_providing: false, | ||
| nodes: DEFAULT_NODES.iter().map(|s| s.to_string()).collect(), | ||
| nodes: load_cache_sources(std::env::var("CACHE_SOURCE_CONFIG_PATH").ok().as_deref()) |
Member
There was a problem hiding this comment.
I'd be surprised if this works: I think we need to do some special things when starting a process for it to see env vars
Member
|
Was this replaced by #858? If so can we close this? |
Collaborator
Author
|
Oh right, #858 replaced this one too! Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Allow users to specify default RPC and node cache source overrides so that they aren't stuck using our defaults
Solution
RPC already allows default overriding, now cache source does do.
Still requires doc, will edit this description and add it as I test and review.