-
Notifications
You must be signed in to change notification settings - Fork 19
Custom router set selection for indirect nodes, cache sources, and Base L2 Access URLs (Dw/router designation) #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nick1udwig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor comments, then go ahead and merge. Really nice work 🚀
tos
"By registering a name, you agree to the terms of service at hyperwareware.xyz/tos."
remove the tos
indirect node specification prose
lets change the prose here
- Network Options -> Advanced Network Options
- "Register as indirect node with non-default routers."
|
Fixes made (ugh, that TOS one was an embarrassing miss) and pushed to this branch, but holding off on merging and closing because the latest "development" commits no longer compile successfully for me (neither does a clean clone of the "develop" branch HEAD). |
|
All set. Merging. |
Problem
Hyperdrive relies on some difficult- or impossible-to-override defaults for routers, Base L2 access points, and cache sources, many of which are our own infrastructure. This is not tenable long-term.
Solution
The CommitDotOsName, MintCustom, and ResetName pages now feature a Network Options section for overriding routers if desired, and the Login (register-served, not hyperdrive-served) and SetPassword pages feature a new Advanced Options for setting cache sources and Base L2 wss:// access points.
Testing
These features should all behave intuitively. The front end will enforce that the inputs are sane, but they do not check to ensure that the nodes or URLs provided can actually provide the services requested.
Docs Update
Docs must be updated to capture this new ability.
Notes
The Base L2 access URLs are only added to the existing providers (there is a deduplication step, so adding an existing URL moves it to the top of the list), but currently only the terminal script "remove-provider" (or directly editing .eth_providers) will remove Base L2 access providers.
A future --no-defaults launch flag would be a good complementary addition to prevent accidental defaulting for those who do not want to or cannot use our infrastructure.