Eth module handler #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick1udwig
approved these changes
Sep 4, 2025
| println!("ETH subscription error: id={}, error={}", | ||
| eth_sub_error.id, eth_sub_error.error); | ||
| "Subscription error handled".to_string() | ||
| } |
There was a problem hiding this comment.
show the conventional resubscribe logic here
| // Handle error asynchronously | ||
| self.log_eth_error(ð_sub_error).await; | ||
| "Error logged".to_string() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much followed the same pattern from the codebase. I haven't interfaced with the module a lot so I don't have intuition, but a question is how do we deserialize the message body? Do we restrict what can be put in the function signature of the eth handler (similar to WS handler)?