Switch dev-ui command to use npm run dev#112
Merged
nick1udwig merged 5 commits intomasterfrom Mar 30, 2024
Merged
Conversation
dev-ui should run `npm run dev` not `npm start`
Member
|
Comment in general before diving in to the review: we don't currently enforce rustfmt on this repo and I don't want to until I can look into how to make it not make certain cases less readable IMO, see #74 However, I know you and some others have editors configured to auto-rustfmt, and that makes it harder to review PRs because there are lots of lines changed that are just formatting. Is there a way you can toggle this behavior so you are not making lots of formatting changes here/in future? |
nick1udwig
approved these changes
Mar 21, 2024
Member
nick1udwig
left a comment
nick1udwig
left a comment
There was a problem hiding this comment.
Added some comments. Please address, then good to merge. Thanks for this work!
gusapps
approved these changes
Mar 21, 2024
Contributor
gusapps
left a comment
gusapps
left a comment
There was a problem hiding this comment.
Tested this with fake-node and it does what was intended 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend build command should use a fast debug build unless developer specifically wants to build for release. To this end, we switch
dev-uito usenpm run devunless the--releaseflag is passed, in which case it will usenpm start.kit bwill remain unchanged.