build: concurrent-ify compile_package()#126
Merged
nick1udwig merged 1 commit intomasterfrom Apr 2, 2024
Merged
Conversation
in testing building a package with four processes, master took 55s wall time whereas this branch took 41s wall time on my machine (i7-1280P)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building multiple-process packages is slow.
Solution
Concurrent-ify the previously sequential
compile_package().Docs Update
N/A
Notes
In testing building a package with four processes, master took 55s wall time whereas this branch took 41s wall time on my machine (i7-1280P).