buffer runtime std; mostly working (found run-tests bug; wip)#162
Merged
nick1udwig merged 3 commits intomasterfrom May 17, 2024
Merged
buffer runtime std; mostly working (found run-tests bug; wip)#162nick1udwig merged 3 commits intomasterfrom
nick1udwig merged 3 commits intomasterfrom
Conversation
Member
Author
|
Re: notes: it is working now. I guess some combination of:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #145
Solution
Spin up a task to read in runtime stdout/stderr as lines come in so pipe never overflows
Docs Update
None
Notes
In testing, found a bug in run-tests. In fixing that bug, found a bug (?) in booting fake nodes that appears to be on master as well. Namely, first fake node does not appear to connect to anvil, though subsequent nodes do. So, e.g., if I start 3 nodes, 2 & 3 can talk, but 1 cannot. Will work with @bitful-pannul on this.