build: cache downloads with sha hash of url not hex encoding#223
Merged
nick1udwig merged 1 commit intov0.7.2from Sep 3, 2024
Merged
build: cache downloads with sha hash of url not hex encoding#223nick1udwig merged 1 commit intov0.7.2from
nick1udwig merged 1 commit intov0.7.2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long URLs can fail to be hashed -> fail to be cached -> fail out. Resolves #218
Solution
Instead of hex-encoding URLs, sha256 hash them.
Docs Update
None
Notes
None